We need AniMap only for test purposes so it would be better to make the
typedef protected (and mark as internal as well).
Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Commits
- R108:dffd9777c744: [libkwineffects] Make AnimationEffect::AniMap protected
Compiles.
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Branch
- reformat-doc-strings
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 6407 Build 6425: arc lint + arc unit
Comment Actions
If we're going to use auto everywhere we don't need the typedef at all, it's only really there to save typing rather than having any semantic value.
Comment Actions
Well, it's still used in kwinanimationeffect.cpp. Should I go for it?
Your choice.
I'll approve either