[libkwineffects] Make AnimationEffect::AniMap protected
ClosedPublic

Authored by zzag on Dec 28 2018, 4:32 PM.

Details

Summary

We need AniMap only for test purposes so it would be better to make the
typedef protected (and mark as internal as well).

Test Plan

Compiles.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Dec 28 2018, 4:32 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 28 2018, 4:32 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Dec 28 2018, 4:32 PM

If we're going to use auto everywhere we don't need the typedef at all, it's only really there to save typing rather than having any semantic value.

zzag added a comment.Jan 8 2019, 1:03 PM

If we're going to use auto everywhere we don't need the typedef at all, it's only really there to save typing rather than having any semantic value.

Well, it's still used in kwinanimationeffect.cpp. Should I go for it?

davidedmundson accepted this revision.Feb 25 2019, 10:16 AM

Well, it's still used in kwinanimationeffect.cpp. Should I go for it?

Your choice.

I'll approve either

This revision is now accepted and ready to land.Feb 25 2019, 10:16 AM
This revision was automatically updated to reflect the committed changes.