Differential D17820

[tagsfiap] Use tag-new icon for New Tag action
ClosedPublic
Actions

Authored by nicolasfella on Dec 27 2018, 2:51 PM.

Details

Reviewers
ngraham
shubham
Group Reviewers
Baloo
Commits
R824:742da27b5b13: [tagsfiap] Use tag-new icon for New Tag action
Summary

Diff Detail

Repository
R824 Baloo Widgets
Branch
plus
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6387
Build 6405: arc lint + arc unit
nicolasfella created this revision.Dec 27 2018, 2:51 PM
Restricted Application added a project: Baloo. · View Herald TranscriptDec 27 2018, 2:51 PM
nicolasfella requested review of this revision.Dec 27 2018, 2:51 PM
nicolasfella edited the summary of this revision. (Show Details)Dec 27 2018, 2:53 PM
shubham added a subscriber: shubham.Dec 27 2018, 2:54 PM

should not it be tag-new ?

nicolasfella added a comment.Dec 27 2018, 2:56 PM
In D17820#382708, @shubham wrote:

should not it be tag-new ?

That makes a lot of sense :D

nicolasfella updated this revision to Diff 48250.Dec 27 2018, 2:57 PM
  • Use tag-new
shubham added a comment.EditedDec 27 2018, 2:58 PM

This is better, thanks. Can you please update the Screenshot too?

nicolasfella retitled this revision from [tagsfiap] Use add icon for New Tag action to [tagsfiap] Use tag-new icon for New Tag action.Dec 27 2018, 2:58 PM
nicolasfella edited the summary of this revision. (Show Details)
shubham accepted this revision.Dec 27 2018, 3:00 PM
This revision is now accepted and ready to land.Dec 27 2018, 3:00 PM
Closed by commit R824:742da27b5b13: [tagsfiap] Use tag-new icon for New Tag action (authored by nicolasfella). · Explain WhyDec 27 2018, 3:11 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Dec 27 2018, 4:15 PM

Retroactive +1!

Revision Contents
Changeset List

Diff 48250

View Options

src/tagsfileitemactionplugin/tagsfileitemaction.cpp

Loading...