Include applets/22
ClosedPublic

Authored by nicolasfella on Dec 25 2018, 3:25 PM.

Details

Reviewers
ndavis
Group Reviewers
Breeze
Commits
R266:d5a2b47c2d37: Include applets/22
Summary

I noticed that plasma-pa doesn't show an icon for my connected speakers. Turns out the icon (hifi) exists in applets/22 but Cuttlefish doesn't show it.

Test Plan

Cuttlefish and plasma-pa now show the hifi icon

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Dec 25 2018, 3:25 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 25 2018, 3:25 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Dec 25 2018, 3:25 PM

Thinking about it, is there a particular reason why those icons are in the 22 folder in the first place? They are all svgs after all

ndavis added a subscriber: ndavis.EditedDec 25 2018, 11:24 PM

Thinking about it, is there a particular reason why those icons are in the 22 folder in the first place? They are all svgs after all

While we do use SVGs for scalability, SVGs still need to be designed for different sizes, otherwise they will look ugly and blurry at sizes that aren't whole number multiples or factors of the original size. A 22px icon scaled down to 16px or a 16px icon scaled up to 22px will be blurry. This looks especially bad with line art.

What is questionable is the purpose for keeping those specific icons in there. All of them can be categorized as device icons, with the car being arguably a device.

ndavis requested changes to this revision.Dec 28 2018, 8:24 PM

This needs to be rebased

This revision now requires changes to proceed.Dec 28 2018, 8:24 PM
  • Rebase
  • add to Breeze dark
ndavis accepted this revision.Jan 13 2019, 5:04 AM
This revision is now accepted and ready to land.Jan 13 2019, 5:04 AM
This revision was automatically updated to reflect the committed changes.