Extend getExtensionFromPatternList reg exp filtering
ClosedPublic

Authored by davidedmundson on Dec 22 2018, 10:29 PM.

Details

Summary

getExtensionFromPatternList turns a filter string such "*.cpp" etc into
an extension ".cpp".

It tries to filter out any filter string that could be a glob pattern.
However it didn't handle "[]" characters.

See https://phabricator.kde.org/D17677 and D17738

Test Plan

Modified kfilewidgettest_gui test and confirmed
that "automatically select file extension" checkbox didn't
insert irrelevant chars in the filename.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 22 2018, 10:29 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 22 2018, 10:29 PM
jgrulich accepted this revision.Dec 23 2018, 10:18 AM
This revision is now accepted and ready to land.Dec 23 2018, 10:18 AM
This revision was automatically updated to reflect the committed changes.