Gtk can use filter patterns, looking like "*.[Pp][Nn][Gg]" to handle all possible lowercase/uppercase
variants. This is unfortunately not supported by KDE/Qt dialogs so we should try to convert it to
just "*.png" instead. There are other possible patterns, but this is probably the most common one.
BUG: 399889
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/filechooser.cpp | ||
|---|---|---|
| 287 | Given this is the plasma portal, it might be a good case to use the KFileWidget directly rather than have a proxy layer in the way which converts filter strings back again. KFileWidget::setFilter takes an expression directly - and if it doesn't match perfectly we can change KIO to come up with something that does. | |
| src/filechooser.cpp | ||
|---|---|---|
| 287 | This can be done of course, but it will not fix this problem. It's reasonable to use it directly and maybe add support for regular expressions in filters to KIO, but this is something what will need more work and require changes on two places. I would like to have now a workaround that can be pushed to stable Plasma release now. | |
| src/filechooser.cpp | ||
|---|---|---|
| 287 | KFileWidget::setFilter exists and takes regular expressions already. | |
| src/filechooser.cpp | ||
|---|---|---|
| 287 | Does it really support regexp in this form? If so, why it doesn't work when used by plasma-integration? I see plasma-integration internally uses KFileWidget and passes filters to it. | |
| src/filechooser.cpp | ||
|---|---|---|
| 287 | It should do: It goes through: QRegExp rx(p);
rx.setPatternSyntax(QRegExp::Wildcard);Wildcard in the Qt docs sounds very much like the "glob" format that's in the XDG spec. Running ./kfilewidgettest_gui in kio/bin you can type a filter manually I did: It doesn't work in plasma-integration because it goes through a method qt2KdeFilter - to turn Qt's weird custom syntax into reg ex patterns. | |
I have now a new version using KFileWidget and it still suffers from the same problem. It does filter properly when I use regexp, but the "automatic extension" feature will add the file extension unmodified so it results into the same problem. It looks that my workaround will be needed anyway.
but the "automatic extension" feature will add the file extension unmodified
Can you expand on what this means.
If you try to save a file and you use for example *.[Pp][Nn][Gg] as a filter, the "automaticly select filename extension" checkbox in the dialog will automatically set "filename.[Pp][Nn][Gg]" as the selected file, same happens if you switch beetween filters.
Thanks for working on this. Given we need a kio patch if you want to put this in just the stable branch, go for it.