Don't delete what was new[]'ed

Authored by adridg on Dec 22 2018, 3:22 PM.



Match new[] with delete[] -- reported by Clang 6

Diff Detail

R466 Kaffeine
No Linters Available
No Unit Test Coverage
Build Status
Buildable 6261
Build 6279: arc lint + arc unit
adridg requested review of this revision.Dec 22 2018, 3:22 PM
adridg created this revision.

This one accidentally also contains the changes from D17735

adridg retitled this revision from Don't assume someone else pulls in errno.h to Don't delete what was new[]'ed.Dec 22 2018, 3:30 PM
adridg edited the summary of this revision. (Show Details)
pino added a subscriber: pino.Dec 22 2018, 3:30 PM

Sounds OK -- can you please clean this review request, please?

adridg updated this revision to Diff 48010.Dec 22 2018, 3:31 PM

See if arc diff HEAD^ does what I wanted.

pino accepted this revision.Dec 22 2018, 3:38 PM
This revision is now accepted and ready to land.Dec 22 2018, 3:38 PM
mauroc accepted this revision.Dec 22 2018, 3:42 PM

Good catch.

I noticed that Clang 7 generated a few other warnings. Already fixed upstream. Feel free to merge this fix directly there (or ping me if you prefer otherwise).

This revision was automatically updated to reflect the committed changes.