Differential D17736

Don't delete what was new[]'ed
ClosedPublic
Actions

Authored by adridg on Dec 22 2018, 3:22 PM.

Details

Reviewers
mauroc
pino
Commits
R466:06d54c931045: Don't delete what was new[]'ed
Summary

Match new[] with delete[] -- reported by Clang 6

Diff Detail

Repository
R466 Kaffeine
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adridg requested review of this revision.Dec 22 2018, 3:22 PM
adridg created this revision.
adridg added a reviewer: mauroc.Dec 22 2018, 3:24 PM

This one accidentally also contains the changes from D17735

adridg retitled this revision from Don't assume someone else pulls in errno.h to Don't delete what was new[]'ed.Dec 22 2018, 3:30 PM
adridg edited the summary of this revision. (Show Details)
pino added a subscriber: pino.Dec 22 2018, 3:30 PM

Sounds OK -- can you please clean this review request, please?

adridg updated this revision to Diff 48010.Dec 22 2018, 3:31 PM

See if arc diff HEAD^ does what I wanted.

pino accepted this revision.Dec 22 2018, 3:38 PM
This revision is now accepted and ready to land.Dec 22 2018, 3:38 PM
mauroc accepted this revision.Dec 22 2018, 3:42 PM

Good catch.

mauroc added a comment.Dec 22 2018, 4:13 PM

I noticed that Clang 7 generated a few other warnings. Already fixed upstream. Feel free to merge this fix directly there (or ping me if you prefer otherwise).

Closed by commit R466:06d54c931045: Don't delete what was new[]'ed (authored by adridg). · Explain WhyDec 22 2018, 4:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/backend-vlc/vlcmediawidget.cpp (4 lines)

Diff 48013

View Options

src/backend-vlc/vlcmediawidget.cpp

Loading...