Histogram Improvements
AbandonedPublic
Actions

Authored by eingerman on Jun 4 2016, 9:21 PM.

Details

Reviewers

dkazakov
rempt
Deevad

Summary

Improved histogram display in Layers->Histogram. Show multiple colors.

New

Old:

Added histogram docker widget.

Improved Ko*HistogramProducer classes. They were not handling displaying different color space histograms correctly - data was just converted to different bit depth. Histogram data has to be converted to the requested color space for the histogram to make sense.

Sorry about the massive patch.

Test Plan

Open an image.
Layers->Histogram. Check that histogram makes sense.
Select different color channel (e.g. CMYK or Lab). Make sure histogram changes and displays correctly.
Close dialog.
Enable 'Histogram' docker. Make sure it is visible.
Convert image to different color space (e.g. CMYK). Check that histogram changes.
Change image brightness/color. Check that image changes correctly.

Diff Detail

Repository

R37 Krita

Lint

Lint Skipped

Unit

Unit Tests Skipped

eingerman updated this revision to Diff 4206.Jun 4 2016, 9:21 PM

eingerman retitled this revision from to Histogram Improvements.

eingerman updated this object.

eingerman edited the test plan for this revision. (Show Details)

eingerman added reviewers: Deevad, dkazakov, rempt.

eingerman set the repository for this revision to R37 Krita.

Pretty good! Fix the copyrights, and we can push it. Do you already have commit access?

plugins/dockers/histogram/histogramdocker.h
3	This is a new docker, right? Then it should have your copyright, not Cyrille's!

This revision is now accepted and ready to land.Jun 5 2016, 12:42 PM

Fixed copyright notices.

I don't have commit access. Please merge if the changes are Ok.

Reminder to merge this diff.

rempt mentioned this in R37:2dd26c598e1e: Histogram Improvements.Jun 9 2016, 6:27 AM

The histogram docker is currently killing performance in master so I have had to disable it: can you please fix the performance issue? See https://bugs.kde.org/show_bug.cgi?id=364406 . This is really urgent!

This revision now requires changes to proceed.Jun 18 2016, 10:59 AM

It may take me a few days to fix it properly. Working on it.

Awesome!

Hi, @eingerman!

Has this patch/branch been merged into master?

This change has been merged as part of D1979 revision. Closing.

Revision Contents
Changeset List

		Path
M		libs/pigment/KoBasicHistogramProducers.h (11 lines)
M		libs/pigment/KoBasicHistogramProducers.cpp (98 lines)
M		libs/pigment/KoHistogramProducer.h (4 lines)
M		libs/pigment/KoHistogramProducer.cpp (5 lines)
M		libs/ui/kis_histogram_view.h (55 lines)
M		libs/ui/kis_histogram_view.cc (384 lines)
M		plugins/dockers/CMakeLists.txt (1 line)
A	M	plugins/dockers/histogram/CMakeLists.txt (4 lines)
A	M	plugins/dockers/histogram/histogramdocker.h (39 lines)
A	M	plugins/dockers/histogram/histogramdocker.cpp (87 lines)
A	M	plugins/dockers/histogram/histogramdocker_dock.h (54 lines)
A	M	plugins/dockers/histogram/histogramdocker_dock.cpp (94 lines)
A	M	plugins/dockers/histogram/krita_histogramdocker.json (9 lines)
M		plugins/extensions/histogram/kis_histogram_widget.h (30 lines)
M		plugins/extensions/histogram/kis_histogram_widget.cc (137 lines)