eingerman (Eugene Ingerman)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 20 2016, 6:36 PM (220 w, 6 d)
Availability
Available

Recent Activity

Jul 5 2017

eingerman added a comment to T6162: Add information about Smart patch when released.

@timotheegiet @woltherav A new icon would be great. Thank you! It's far beyond my artistic abilities :)

Jul 5 2017, 3:04 AM · Krita: Manual

May 4 2017

eingerman committed R37:ec5837d18ab5: Healing brush tool (authored by eingerman).
Healing brush tool
May 4 2017, 4:02 AM
eingerman closed D5327: Healing brush tool by committing R37:ec5837d18ab5: Healing brush tool.
May 4 2017, 4:02 AM
eingerman committed R37:0f90ae0d0d05: Removed default pixel for mask. Ref T3589 (authored by eingerman).
Removed default pixel for mask. Ref T3589
May 4 2017, 3:50 AM
eingerman committed R37:fff9d121b210: Merge branch 'master' into eingerman/T3589-healbrush (authored by eingerman).
Merge branch 'master' into eingerman/T3589-healbrush
May 4 2017, 3:50 AM
eingerman added a commit to T3589: Create smart fill brush: R37:0f90ae0d0d05: Removed default pixel for mask. Ref T3589.
May 4 2017, 3:50 AM · Krita: Next Features (Needs Documentation), Krita: Manual
eingerman committed R37:3ea909549899: Merge branch 'master' into eingerman/T3589-healbrush (authored by eingerman).
Merge branch 'master' into eingerman/T3589-healbrush
May 4 2017, 3:50 AM

Apr 30 2017

eingerman updated the diff for D5327: Healing brush tool.

Fixed the diff. Previous one was against wrong version.

Apr 30 2017, 11:05 PM
eingerman updated the diff for D5327: Healing brush tool.

Thank you for the careful review. Using KisTransactionBasedCommand simplified undo handling a lot!

Apr 30 2017, 11:00 PM
eingerman committed R37:82e00c7973fe: Removed outdated files. (authored by eingerman).
Removed outdated files.
Apr 30 2017, 10:47 PM
eingerman committed R37:0841dc9e991e: Addressed code review comments. (authored by eingerman).
Addressed code review comments.
Apr 30 2017, 10:47 PM
eingerman committed R37:f4e5bdc897da: Removed outdated files. (authored by eingerman).
Removed outdated files.
Apr 30 2017, 10:47 PM

Apr 28 2017

eingerman updated the diff for D5327: Healing brush tool.

Rewrote healing brush to use decorator. Changed ui to adjust brush size using keyboard and toolbar size control. Rewrote image access using Applicator based undo/redo interface.

Apr 28 2017, 7:55 AM
eingerman committed R37:6ac411594c13: Removed unused include files. Code cleanup. (authored by eingerman).
Removed unused include files. Code cleanup.
Apr 28 2017, 7:42 AM
eingerman committed R37:ab0cf62a236f: Handle keyboard signals for brush size change for smart patch tool. (authored by eingerman).
Handle keyboard signals for brush size change for smart patch tool.
Apr 28 2017, 7:06 AM

Apr 27 2017

eingerman committed R37:d821e1d82794: Enable brush size change for smart patch tool. (authored by eingerman).
Enable brush size change for smart patch tool.
Apr 27 2017, 7:18 AM

Apr 26 2017

eingerman committed R37:68b3e732e562: Enable handling undo operations correctly. (authored by eingerman).
Enable handling undo operations correctly.
Apr 26 2017, 7:19 AM

Apr 24 2017

eingerman committed R37:614e5352c031: Reenabled inpaint. (authored by eingerman).
Reenabled inpaint.
Apr 24 2017, 7:29 AM
eingerman committed R37:a574899fc108: Switched to using KisTool::paint for decorations. (authored by eingerman).
Switched to using KisTool::paint for decorations.
Apr 24 2017, 7:29 AM
eingerman committed R37:9320b04e54f1: Merge branch 'master' into eingerman/T3589-healbrush (authored by eingerman).
Merge branch 'master' into eingerman/T3589-healbrush
Apr 24 2017, 7:29 AM

Apr 9 2017

eingerman added a comment to D5327: Healing brush tool.

I guess that one reason to use a mask and not a canvas decoration is that the inpaint tool can be used with any brush engine.

I doubt there is any use in allowing multiple brush engines for painting healing selection. It'll create more troubles than benefits, like in Colorize mask, where it is still in todo to disable incompatible presets for it. I guess simple pixel brush is the only thing compatible with it.

Apr 9 2017, 5:12 AM

Apr 8 2017

eingerman closed T3589: Create smart fill brush as Resolved.
Apr 8 2017, 6:37 AM · Krita: Next Features (Needs Documentation), Krita: Manual
eingerman added a comment to R37:4de33f29feb5: Should build the collection tree.

Description is incorrect. I don't know where arc got it from :) . It wasn't me :)

Apr 8 2017, 6:33 AM
eingerman added a task to R37:4de33f29feb5: Should build the collection tree: T3589: Create smart fill brush.
Apr 8 2017, 6:31 AM
eingerman added a commit to T3589: Create smart fill brush: R37:4de33f29feb5: Should build the collection tree.
Apr 8 2017, 6:31 AM · Krita: Next Features (Needs Documentation), Krita: Manual
eingerman edited edges for R37:4de33f29feb5: Should build the collection tree, added: D5327: Healing brush tool; removed Unknown Object (Differential Revision).
Apr 8 2017, 6:30 AM
eingerman added 1 commit(s) for D5327: Healing brush tool: R37:4de33f29feb5: Should build the collection tree.
Apr 8 2017, 6:30 AM
eingerman committed R37:4de33f29feb5: Should build the collection tree (authored by eingerman).
Should build the collection tree
Apr 8 2017, 6:00 AM
eingerman updated the diff for D5327: Healing brush tool.

I added support for all color depths to inpaint tool. It was planned all along but slipped my mind.

Apr 8 2017, 5:43 AM
eingerman committed R37:d4ba11f3200a: Handle all color spaces and bit depths. (authored by eingerman).
Handle all color spaces and bit depths.
Apr 8 2017, 5:38 AM
eingerman committed R37:725a64785020: Code cleanup. (authored by eingerman).
Code cleanup.
Apr 8 2017, 5:38 AM

Apr 7 2017

eingerman updated the test plan for D5327: Healing brush tool.
Apr 7 2017, 4:39 AM
eingerman added a comment to D5327: Healing brush tool.

This change adds a few strings that need to be i18n

Apr 7 2017, 4:37 AM
eingerman created D5327: Healing brush tool.
Apr 7 2017, 4:32 AM
eingerman committed R37:35b9974c09a0: Fixed message typo. (authored by eingerman).
Fixed message typo.
Apr 7 2017, 3:55 AM
eingerman committed R37:9d82ff1426d5: Merge branch 'master' into eingerman/T3589-healbrush (authored by eingerman).
Merge branch 'master' into eingerman/T3589-healbrush
Apr 7 2017, 3:55 AM

Apr 6 2017

eingerman committed R37:eff3a2ac4044: Cleaned up code style. (authored by eingerman).
Cleaned up code style.
Apr 6 2017, 6:39 AM
eingerman committed R37:092711f49daa: Added check for paint layer. Added error message. (authored by eingerman).
Added check for paint layer. Added error message.
Apr 6 2017, 6:31 AM

Apr 4 2017

eingerman committed R37:ed79db819a68: Code cleanup (authored by eingerman).
Code cleanup
Apr 4 2017, 7:01 AM

Mar 28 2017

eingerman committed R37:1e8dd68b3985: Merge branch 'master' into eingerman/T3589-healbrush (authored by eingerman).
Merge branch 'master' into eingerman/T3589-healbrush
Mar 28 2017, 6:20 AM
eingerman committed R37:c8919dadae12: Added wait cursor. Improved defaults. (authored by eingerman).
Added wait cursor. Improved defaults.
Mar 28 2017, 5:48 AM
eingerman added a comment to T3589: Create smart fill brush.

Demo of the new inpaint tool from my branch:
https://youtu.be/jI87VzDtkPY

Mar 28 2017, 5:41 AM · Krita: Next Features (Needs Documentation), Krita: Manual

Mar 27 2017

eingerman committed R37:fb2c2cad1e4f: Fixed inpaint. (authored by eingerman).
Fixed inpaint.
Mar 27 2017, 6:46 AM
eingerman committed R37:21df6cacca63: Cleanup includes. (authored by eingerman).
Cleanup includes.
Mar 27 2017, 6:46 AM
eingerman committed R37:405137ec175a: Correct handling of undo operation for inpaint. (authored by eingerman).
Correct handling of undo operation for inpaint.
Mar 27 2017, 1:02 AM
eingerman committed R37:2b4d8188183c: Fixed temporary layer deletion. (authored by eingerman).
Fixed temporary layer deletion.
Mar 27 2017, 1:02 AM

Mar 25 2017

eingerman committed R37:b971f215c454: Create inpaint layer manually. Avoids messing undo/redo stack. (authored by eingerman).
Create inpaint layer manually. Avoids messing undo/redo stack.
Mar 25 2017, 6:27 AM

Mar 23 2017

eingerman committed R37:f45b4a384b42: Small UI adjustments. Correct area to copy. (authored by eingerman).
Small UI adjustments. Correct area to copy.
Mar 23 2017, 7:00 AM
eingerman committed R37:a3ae72b1e186: Added UI. Correct painting. (authored by eingerman).
Added UI. Correct painting.
Mar 23 2017, 6:31 AM

Mar 22 2017

eingerman committed R37:323b116421ee: First working inpaint version (authored by eingerman).
First working inpaint version
Mar 22 2017, 7:02 AM

Mar 21 2017

eingerman committed R37:6e56c6e86874: Checkpoint (authored by eingerman).
Checkpoint
Mar 21 2017, 6:46 AM
eingerman committed R37:f9be6764ae82: Checkpoint (authored by eingerman).
Checkpoint
Mar 21 2017, 6:46 AM
eingerman committed R37:fbd1c7faa99f: Checkpoint (authored by eingerman).
Checkpoint
Mar 21 2017, 6:46 AM
eingerman committed R37:528cd1f44792: Checkpoint (authored by eingerman).
Checkpoint
Mar 21 2017, 6:46 AM
eingerman committed R37:13c332842016: Checkpoint (authored by eingerman).
Checkpoint
Mar 21 2017, 6:46 AM
eingerman committed R37:1ba8fa4634f8: Fixed incorrect size check. (authored by eingerman).
Fixed incorrect size check.
Mar 21 2017, 6:46 AM
eingerman committed R37:c02e6dd6d837: Inpaint test code cleanup. (authored by eingerman).
Inpaint test code cleanup.
Mar 21 2017, 6:46 AM
eingerman committed R37:12e3785603fa: Working fast implementation of patch match. (authored by eingerman).
Working fast implementation of patch match.
Mar 21 2017, 6:46 AM
eingerman committed R37:f1c556561fbd: Merge with master. (authored by eingerman).
Merge with master.
Mar 21 2017, 6:46 AM
eingerman committed R37:48b10685766e: Checkpoint (authored by eingerman).
Checkpoint
Mar 21 2017, 6:46 AM
eingerman committed R37:d167f177eba5: Merge with current dev branch (authored by eingerman).
Merge with current dev branch
Mar 21 2017, 6:46 AM
eingerman committed R37:67a9b8c59146: checkpoint (authored by eingerman).
checkpoint
Mar 21 2017, 6:46 AM
eingerman committed R37:6ab63d122de7: Checkpoint. Works with transform worker. Merged. (authored by eingerman).
Checkpoint. Works with transform worker. Merged.
Mar 21 2017, 6:46 AM
eingerman committed R37:bbac140f2c18: Working version. Ported from c code. (authored by eingerman).
Working version. Ported from c code.
Mar 21 2017, 6:46 AM
eingerman committed R37:ac4636c70ba7: Checkpoint. Alternative implementation of inpaint. (authored by eingerman).
Checkpoint. Alternative implementation of inpaint.
Mar 21 2017, 6:46 AM
eingerman committed R37:1729c2836ae4: Checkpoint. Alternative implementation of inpaint. (authored by eingerman).
Checkpoint. Alternative implementation of inpaint.
Mar 21 2017, 6:46 AM
eingerman committed R37:e605ba095015: Checkpoint. Works with transform worker. (authored by eingerman).
Checkpoint. Works with transform worker.
Mar 21 2017, 6:46 AM
eingerman committed R37:a824c03c76a8: Merge (authored by eingerman).
Merge
Mar 21 2017, 6:46 AM
eingerman committed R37:9a25e3d7d666: Checkpoint (authored by eingerman).
Checkpoint
Mar 21 2017, 6:46 AM
eingerman committed R37:cd9e3bac9750: Merge (authored by eingerman).
Merge
Mar 21 2017, 6:46 AM
eingerman committed R37:ea8b9bc4a72c: Checkpoint. Alternative implementation of inpaint. (authored by eingerman).
Checkpoint. Alternative implementation of inpaint.
Mar 21 2017, 6:46 AM
eingerman committed R37:79636099b05c: Checkpoint (authored by eingerman).
Checkpoint
Mar 21 2017, 6:46 AM
eingerman committed R37:a9df189e965d: Checkpoint (authored by eingerman).
Checkpoint
Mar 21 2017, 6:46 AM
eingerman committed R37:2ed5594b55fd: Checkpoint. Partially working. (authored by eingerman).
Checkpoint. Partially working.
Mar 21 2017, 6:46 AM
eingerman committed R37:4ada62414eb4: Checkpoint. Fast, partially working. (authored by eingerman).
Checkpoint. Fast, partially working.
Mar 21 2017, 6:46 AM
eingerman committed R37:a16156c07a81: Checkpoint (authored by eingerman).
Checkpoint
Mar 21 2017, 6:46 AM

Sep 21 2016

eingerman closed T3591: Fix EXIF dialog as Resolved.

Fixed.

Sep 21 2016, 6:22 AM
eingerman committed R37:29a4d272cf89: Fixed metadata editor. Resource file extension had been changed, but code in… (authored by eingerman).
Fixed metadata editor. Resource file extension had been changed, but code in…
Sep 21 2016, 6:21 AM
eingerman added a commit to T3591: Fix EXIF dialog: R37:29a4d272cf89: Fixed metadata editor. Resource file extension had been changed, but code in….
Sep 21 2016, 6:21 AM

Sep 20 2016

eingerman committed R37:52c1cfcfd2f8: Check pointer before using it. Fixing assert when image is open from command… (authored by eingerman).
Check pointer before using it. Fixing assert when image is open from command…
Sep 20 2016, 4:58 AM

Sep 9 2016

eingerman added a comment to T3588: Investigate PythonQt based scripting.

Actually, I'm going to change my mind. PythonQt may still be the simplest path to enabling krita scripting.

Sep 9 2016, 5:52 AM · Krita: Next Features

Sep 8 2016

eingerman added a comment to T3588: Investigate PythonQt based scripting.

I did a bit of testing and I think I can kill the PythonQt idea. PythonQt seems to have limited capability of automatically wrapping C++ objects.

Sep 8 2016, 6:54 AM · Krita: Next Features

Sep 7 2016

eingerman added a comment to T3591: Fix EXIF dialog.

Yes. I'll adopt the poor orphan :)

Sep 7 2016, 6:26 PM
eingerman added a comment to T3588: Investigate PythonQt based scripting.
Sep 7 2016, 6:25 PM · Krita: Next Features

Sep 3 2016

eingerman created T3591: Fix EXIF dialog.
Sep 3 2016, 9:29 PM
eingerman created T3590: Group operation layer.
Sep 3 2016, 5:14 PM · Krita: Next Features
eingerman created T3589: Create smart fill brush.
Sep 3 2016, 5:08 PM · Krita: Next Features (Needs Documentation), Krita: Manual
eingerman updated the task description for T3588: Investigate PythonQt based scripting.
Sep 3 2016, 5:01 PM · Krita: Next Features
eingerman created T3588: Investigate PythonQt based scripting.
Sep 3 2016, 5:00 PM · Krita: Next Features
eingerman created T3587: Open as layer command line parameter.
Sep 3 2016, 4:55 PM · Krita: Next Features

Sep 2 2016

eingerman committed R37:7c6cf9c123ea: Merge branch 'master' of ssh://phabricator.kde.org/diffusion/KRITA/krita (authored by eingerman).
Merge branch 'master' of ssh://phabricator.kde.org/diffusion/KRITA/krita
Sep 2 2016, 4:32 AM
eingerman committed R37:a38e6ce8cb7b: Merge branch 'eingerman/overviewdocker_bug_367901' (authored by eingerman).
Merge branch 'eingerman/overviewdocker_bug_367901'
Sep 2 2016, 4:32 AM

Sep 1 2016

eingerman committed R37:46ae6ad8996d: Reverting all my changes, they make jenkins sad. (authored by eingerman).
Reverting all my changes, they make jenkins sad.
Sep 1 2016, 6:43 AM
eingerman committed R37:2fef23fdb369: Trying to fix strange jenkins build failure (authored by eingerman).
Trying to fix strange jenkins build failure
Sep 1 2016, 6:09 AM
eingerman committed R37:c3615bdda4c4: Triggering rebuild (authored by eingerman).
Triggering rebuild
Sep 1 2016, 5:30 AM
eingerman committed R37:357d6e2c7429: Splitting tests to satisfy 2min limit that jenkins imposes on tests. (authored by eingerman).
Splitting tests to satisfy 2min limit that jenkins imposes on tests.
Sep 1 2016, 5:02 AM
eingerman committed R37:1bb582c7e422: Merge branch 'master' of ssh://phabricator.kde.org/diffusion/KRITA/krita (authored by eingerman).
Merge branch 'master' of ssh://phabricator.kde.org/diffusion/KRITA/krita
Sep 1 2016, 2:08 AM
eingerman committed R37:d24d56032487: Extending time for projection to finish. This is an attempt to fix jenkins… (authored by eingerman).
Extending time for projection to finish. This is an attempt to fix jenkins…
Sep 1 2016, 2:08 AM
eingerman committed R37:c69ce8c22321: Merge branch 'master' of ssh://phabricator.kde.org/diffusion/KRITA/krita (authored by eingerman).
Merge branch 'master' of ssh://phabricator.kde.org/diffusion/KRITA/krita
Sep 1 2016, 2:08 AM

Aug 31 2016

eingerman committed R37:d8ebc64f5624: Fixing https://bugs.kde.org/show_bug.cgi?id=367901. Removing wait which… (authored by eingerman).
Fixing https://bugs.kde.org/show_bug.cgi?id=367901. Removing wait which…
Aug 31 2016, 5:15 AM