You still need to load the qt catalog, no?

In D1763#32921, @aacid wrote:

You still need to load the qt catalog, no?

Yes, that is what D1764 is about. Hoped separate diffs for different code layers make things less complex :)

In D1763#32923, @kossebau wrote:

In D1763#32921, @aacid wrote:

You still need to load the qt catalog, no?

Yes, that is what D1764 is about. Hoped separate diffs for different code layers make things less complex :)

Ok, do we care about all those TODO you added?

Honestly i don't have time to test this patch this week, but it looks reasonable (with the exception of my comments on D1764 ) so if you have tested it and works, i don't see any reason you should hold up commiting this

@aacid & @nienhueser Thanks for having had a look, will commit tomorrow then.

Hi Friedrich,

Thanks for your effort!

I applied this patch on top of branch Applications/16.04, but somehow it did not make the tr() translations work. I didn't run arc patch D1764 because arc patch D1763 already added the code from that review request.

What I did:
0. (I did _not_ create the en/.../marble_qt.qm translation file.)

1. Generated the new marble_qt.ts for Russian language: "<TS version="2.1" language="ru">". It contains strings "Global Search" and "Distance:", as expected.
2. Translated these two messages into Russian in this .ts file.
3. Run lrelease marble_qt.ts to create marble_qt.qm.
4. cp marble_qt.qm ~/.local/share/locale/ru/LC_MESSAGES/marble_qt.qm
5. Run "strace marble".

I see Marble try to open en/LC_MESSAGES/marble_qt.qm, then successfully open ~/.local/share/locale/ru/LC_MESSAGES/marble_qt.qm, but "Global Search" and "Distance:" are both still in English in the UI.

Hi Alexander,

not idea why things do not work for you yet, I am only learning my way here as well. All I can tell is that trying to simulate the KDE translation process the following way seems to work for me, I get my custom German translations:

PATH=$HOME/Kode/kdesvn/trunk/l10n-kf5/scripts/:$PATH bash ~/Kode/kdesvn/trunk/l10n-kf5/scripts/extract-messages.sh
cp po/marble_qt.pot po/de/marble_qt.po
# here change some strings with lokalize in po/de/marble_qt.po, then...
lconvert-qt5 -i po/de/marble_qt.po -o po/de/marble_qt.ts -target-language de
lrelease-qt5 -removeidentical -silent po/de/marble_qt.ts -qm po/de/marble_qt.qm
sudo cp po/de/marble_qt.qm /usr/share/locale/de/LC_MESSAGES/marble_qt.qm
marble # with this patch in

(which BTW also hints that Marble still is missing respective things in its build system to have the qm file creation done at release time, but one step after the other).