[SMS App] Add highlighting to ConversationList view
ClosedPublic

Authored by sredman on Dec 15 2018, 11:55 PM.

Details

Summary

Let the ListView use its default highlighting (did I not notice before?) and keep the currently-selected chat highlighted at all times

Test Plan
  • Launch app
  • Use mouse or arrow keys to select a conversation. The highlight should follow the selected conversation

Diff Detail

Repository
R224 KDE Connect
Branch
smsapp-highlighting
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8922
Build 8940: arc lint + arc unit
sredman created this revision.Dec 15 2018, 11:55 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 15 2018, 11:55 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Dec 15 2018, 11:55 PM
sredman updated this revision to Diff 47734.Dec 17 2018, 7:23 PM
  • Keep currently-open chat highlighted even when the list loses focus
sredman updated this revision to Diff 47735.Dec 17 2018, 7:25 PM

Only do patch since D17634

apol accepted this revision.Feb 22 2019, 8:05 PM
apol added inline comments.
smsapp/qml/ConversationList.qml
78

That's not necessary.

This revision is now accepted and ready to land.Feb 22 2019, 8:05 PM
sredman updated this revision to Diff 52698.Feb 27 2019, 5:45 AM
  • Remove redundant highlighting configuration
sredman closed this revision.Feb 27 2019, 5:46 AM