- Allow filter box to handle keystrokes passed to the ListView
- This is a little cheesy, but fixes T8341
- Pin filter box to always be visible
- Clear filter on Esc
Details
Details
- Reviewers
apol - Group Reviewers
KDE Connect - Maniphest Tasks
- T8341: Contacts search box does not work
- Commits
- R224:5b213e614498: [SMS App] Improve filter
- Try typing a contact you would like to search for
- Before: Every time you type a new letter, the filter box would lose focus and you would have to click it to give it focus again
- Now: You can type smoothly
- Try scrolling the list
- Before: The filter box disappeared off the top of the screen
- Now: The filter box is always visible
- Try pressing escape
- Before: Nothing
- Now: Filter clears
- Bonus: When using the arrow keys to navigate, before the filter was manually handling those and the view would not loop. Now, the view loops if you try to select an item past the beginning or end (Easiest to see with highlighting from D17612)
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Branch
- smsapp-filter
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 6062 Build 6080: arc lint + arc unit