Otherwise we end up waiting forever without really knowing what
happened.
Details
Details
- Reviewers
leinir - Group Reviewers
Frameworks - Commits
- R235:4c53ebade05a: Notify if a default provider failed to download
Diff Detail
Diff Detail
- Repository
- R235 Attica
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6040 Build 6058: arc lint + arc unit
Comment Actions
Hm, definitely yes. Frankly i thought this already happened, goes to show what assumptions make of us, eh? ;)
Comment Actions
The unittest failed. I kind of fixed it (see commit 32a662b), and my fix works, but it's ugly, it still waits for 5s instead of using that failedToLoad signal.
However when requiring the signal to be emitted (see patch below), the test is unstable (sometimes it passes, sometimes it fails -- ProviderManager::fileFinished isn't called). Any idea why?
http://www.davidfaure.fr/2019/0001-autotests-use-new-signal-failedToLoad-in-ProviderTes.patch