Otherwise we'll keep piling up custom tooltip items in the dialog. They're invisible but they're still there.
Details
Details
- Reviewers
mart - Group Reviewers
Plasma - Commits
- R242:f4bd4a613187: Reset parentItem when mainItem changes
Kept the contentItem visible, moved between TM and kickoff, tooltip no longer ends up with multiple items in it:
Before:
They're not "leaked" as it doesn't change ownership (parent vs parentItem) but it still adds unnccessary invisible items to the window
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
sometimes in the past i had problems about setting parentitem of an item to nullptr, due to all the scenegraph nodes of the item being destroyed and recreated...
somewhere else to do something like that i did have a dummy qquickitem invisible and reparented stuff to that instead of nullptr
this looks cleaner, so i would say go for it and if will cause problems, then go for the above workaround