improve highlighting of complex numbers
ClosedPublic
Actions

Authored by cullmann on Dec 12 2018, 9:43 AM.

Details

Reviewers

dhaumann
vkrause

Group Reviewers

Frameworks

Commits

R216:ea5a88d1df28: improve highlighting of complex numbers

Summary

CHANGELOG: support more variants of C number literals

BUG: 402002

Test Plan

adapted unit tests to cover problematic cases

Repository

R216 Syntax Highlighting

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cullmann requested review of this revision.Dec 12 2018, 9:43 AM

update unit tests

I didn't include rules as I need to rule out the user literal suffixes.

Reviewing correct context popping is always not so easy - I trust this part is correct?! ;)

This revision is now accepted and ready to land.Dec 12 2018, 1:26 PM

It's "stolen" 1:1 from the C++ stuff.

This revision was automatically updated to reflect the committed changes.

Well, if it's copy & pasted, it must be correct ;)

			Path	Packages
M			autotests/folding/test.c.fold (4 lines)
M			autotests/html/test.c.html (10 lines)
M			autotests/input/test.c (4 lines)
M			autotests/reference/test.c.ref (10 lines)
M			data/syntax/c.xml (78 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47429	d4c10b4		Dec 12 2018, 9:43 AM	★	★
Diff 2	47430	d4c10b4	update unit tests	Dec 12 2018, 9:44 AM	★	★
Diff 3	47450	d4c10b4	R216:ea5a88d1df2881f2ea60d850713aab8a59a5c4d5	Dec 12 2018, 9:44 AM	★	★