Differential D17516

[Desktop] Change ThreadID to long
ClosedPublic
Actions

Authored by sredman on Dec 12 2018, 12:32 AM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R224:5cdfb9b087e1: [Desktop] Change ThreadID to long
Summary

Change ThreadID to long

Test Plan

Messages should send and receive as before. Additionally, if your device has assigned extremely large ThreadIDs, the SMS plugin should no longer crash.

This patch corresponds to the Android-side revision D17517

Diff Detail

Repository
R224 KDE Connect
Branch
long-threadid
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5935
Build 5953: arc lint + arc unit
sredman created this revision.Dec 12 2018, 12:32 AM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 12 2018, 12:32 AM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Dec 12 2018, 12:32 AM
sredman mentioned this in D17517: [Android] Change ThreadID to long.Dec 12 2018, 12:37 AM
sredman edited the test plan for this revision. (Show Details)
nicolasfella accepted this revision.Dec 12 2018, 1:01 AM
nicolasfella added a subscriber: nicolasfella.

Didn't test, but looks sane

This revision is now accepted and ready to land.Dec 12 2018, 1:01 AM
Closed by commit R224:5cdfb9b087e1: [Desktop] Change ThreadID to long (authored by sredman). · Explain WhyDec 12 2018, 1:03 AM
This revision was automatically updated to reflect the committed changes.
sredman mentioned this in R225:dda6a5104cf7: [Android] Change ThreadID to long.

Revision Contents
Changeset List

Diff 47399

View Options

interfaces/conversationmessage.h

Loading...
View Options

interfaces/conversationmessage.cpp

Loading...
View Options

plugins/sms/smsplugin.cpp

Loading...