Differential D17517

[Android] Change ThreadID to long
ClosedPublic
Actions

Authored by sredman on Dec 12 2018, 12:32 AM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R225:dda6a5104cf7: [Android] Change ThreadID to long
Summary

Change ThreadID to long

Test Plan

Messages should send and receive as before. Additionally, if your device has assigned extremely large ThreadIDs, the SMS plugin should no longer crash.

This patch corresponds to the KDE-side revision D17516

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
long-threadid
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5936
Build 5954: arc lint + arc unit
sredman created this revision.Dec 12 2018, 12:32 AM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 12 2018, 12:32 AM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sredman requested review of this revision.Dec 12 2018, 12:32 AM
sredman edited the test plan for this revision. (Show Details)Dec 12 2018, 12:37 AM
sredman mentioned this in D17516: [Desktop] Change ThreadID to long.
nicolasfella accepted this revision.Dec 12 2018, 1:00 AM
nicolasfella added a subscriber: nicolasfella.

Didn't test but looks sane

This revision is now accepted and ready to land.Dec 12 2018, 1:00 AM
sredman closed this revision.Dec 12 2018, 1:03 AM

Revision Contents
Changeset List

Diff 47400

View Options

src/org/kde/kdeconnect/Helpers/SMSHelper.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/SMSPlugin/SMSPlugin.java

Loading...