Differential D17490

Add an icon for "restore" action
ClosedPublic
Actions

Authored by shubham on Dec 10 2018, 5:07 PM.

Details

Reviewers
ngraham
Commits
R318:ca25af6d38c8: Add an icon for "restore" action
R318:55db38d5ecc1: Add an icon for "restore" action
Summary

Before:

After:

Test Plan
  1. Go to Trash
  1. Right click any item.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
shubham created this revision.Dec 10 2018, 5:07 PM
Restricted Application added a subscriber: kfm-devel. · View Herald TranscriptDec 10 2018, 5:07 PM
shubham requested review of this revision.Dec 10 2018, 5:07 PM
shubham edited the summary of this revision. (Show Details)Dec 10 2018, 5:14 PM
shubham edited the test plan for this revision. (Show Details)
ngraham accepted this revision.Dec 10 2018, 5:54 PM

Semantically, this is the correct icon, though the actual imagery isn't super applicable. We can fix that with a better icon though.

Ship it!

This revision is now accepted and ready to land.Dec 10 2018, 5:54 PM
Closed by commit R318:55db38d5ecc1: Add an icon for "restore" action (authored by shubham). · Explain WhyDec 10 2018, 5:59 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Dec 10 2018, 6:03 PM

Um, the diff is now different, and it looks like the wrong patch was committed: https://cgit.kde.org/dolphin.git/commit/?id=55db38d5ecc1f13e17fecd7f3a5ea24421080b77

Please revert and commit the original diff that was agreed to in this patch.

shubham reopened this revision.Dec 10 2018, 6:13 PM
This revision is now accepted and ready to land.Dec 10 2018, 6:13 PM
shubham updated this revision to Diff 47309.Dec 10 2018, 6:23 PM
Closed by commit R318:ca25af6d38c8: Add an icon for "restore" action (authored by shubham). · Explain WhyDec 10 2018, 6:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/dolphincontextmenu.cpp (2 lines)

Diff 47310

View Options

src/dolphincontextmenu.cpp

Loading...