Differential D17488

[GCi 2018] GCompris: Fix overriding in Reading.
ClosedPublic
Actions

Authored by turx on Dec 10 2018, 4:40 PM.

Details

Reviewers
amankumargupta
jjazeix
Group Reviewers
GCompris: Improvements
Maniphest Tasks
T8516: reading activities, prevent hiding of the last words by the bar.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
turx created this revision.Dec 10 2018, 4:40 PM
Restricted Application added a subscriber: kde-edu. · View Herald TranscriptDec 10 2018, 4:40 PM
turx requested review of this revision.Dec 10 2018, 4:40 PM
amankumargupta added a subscriber: amankumargupta.Dec 10 2018, 5:03 PM

In vertical reading activity, the last word goes out of the display area: https://pasteboard.co/HR6SkcO.png

amankumargupta requested changes to this revision.Dec 10 2018, 5:03 PM
This revision now requires changes to proceed.Dec 10 2018, 5:03 PM
turx updated this revision to Diff 47301.Dec 10 2018, 5:14 PM
  • Fixed the issue that the last word goes out of the display area in vertical reading activity
jjazeix accepted this revision.Dec 11 2018, 7:24 AM
jjazeix added a subscriber: jjazeix.

seems good now :)

jjazeix added a comment.Dec 11 2018, 7:30 AM

@amankumargupta hi, we can't close a diff if at least one participant put a "changes needed". If it is good with you, can you please accept the revision and close it when you have some time?
I commited the fix in https://commits.kde.org/gcompris/80dd236c8c5da0b2ac1ac711e88d730e3b516544.
Thanks!

This revision is now accepted and ready to land.Dec 11 2018, 7:34 AM

Revision Contents
Changeset List

Diff 47301

View Options

src/activities/readingh/Readingh.qml

Loading...
View Options

src/activities/readingh/resource/reading-bg.svg

Loading...