Differential D17453

[GCi 2018] GCompris: fix "erase" activities layout
ClosedPublic
Actions

Authored by turx on Dec 9 2018, 12:15 PM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris: Improvements
Maniphest Tasks
T8524: erase activities, fix layout.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
turx created this revision.Dec 9 2018, 12:15 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 9 2018, 12:15 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
turx requested review of this revision.Dec 9 2018, 12:15 PM
Restricted Application removed a subscriber: KDE Edu. · View Herald TranscriptDec 9 2018, 12:26 PM
turx updated this revision to Diff 47175.Dec 9 2018, 12:34 PM
  • The blocks are no longer hidden behind the bar on the bottom.
  • If after resizing, the blocks are no longer too small.
jjazeix accepted this revision.Dec 9 2018, 1:54 PM
This revision is now accepted and ready to land.Dec 9 2018, 1:54 PM
turx updated this revision to Diff 47187.Dec 9 2018, 4:21 PM
This comment was removed by turx.
turx updated this revision to Diff 47188.Dec 9 2018, 4:32 PM
  • Fixed the overlapping issue
jjazeix added inline comments.Dec 9 2018, 5:27 PM
src/activities/erase/Block.qml
47

The name is not explicit, and it's complicated to understand what this function does.

src/activities/erase/Erase.qml
140

vert is not defined.
Also, it would be better to use qml bindings instead of a function in this case (so: "bottom: parent.vert ? background.bottom : bar.top)
and use directly parent.vert, instead of adding a "higher" variable.

turx updated this revision to Diff 47228.Dec 10 2018, 2:19 AM
  • Added implementation of the property 'background.vect'
  • Changed function name to make it clearer to read
turx updated this revision to Diff 47229.EditedDec 10 2018, 2:33 AM
  • Removed the use of 'vect' property and 'higher' property
turx marked 2 inline comments as done.Dec 10 2018, 2:34 AM
jjazeix accepted this revision.Dec 10 2018, 7:29 AM

Revision Contents
Changeset List

Diff 47229

View Options

src/activities/erase/Block.qml

Loading...
View Options

src/activities/erase/Erase.qml

Loading...
View Options

src/activities/erase/erase.js

Loading...