Differential D17438

[folder] Initialise LabelGenerator::m_labelMode
AbandonedPublic
Actions

Authored by davidedmundson on Dec 8 2018, 6:20 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

It's giving big warnings in valgrind.

Ultimately I don't think it's a huge issue, as I think it gets bound later
and that rebuilds everything.

Test Plan

Another comment said 1 was the default

Diff Detail

Repository
R119 Plasma Desktop
Branch
Plasma/5.14
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5831
Build 5849: arc lint + arc unit
davidedmundson created this revision.Dec 8 2018, 6:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 8 2018, 6:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 8 2018, 6:20 PM
davidedmundson abandoned this revision.Dec 8 2018, 10:51 PM

That patch needs backporting to stable.

I'll do that now.

apol added a subscriber: apol.Dec 10 2018, 12:40 AM
In D17438#373627, @davidedmundson wrote:

That patch needs backporting to stable.

I'll do that now.

^^' thanks

Revision Contents
Changeset List

Diff 47141

View Options

containments/desktop/plugins/folder/labelgenerator.h

Loading...