Details
- Reviewers
cullmann - Commits
- R216:8741ced7fe71: add attributes `shared` and `__gshared`
Diff Detail
- Repository
- R216 Syntax Highlighting
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Google tells me this are valid attributes: https://dlang.org/spec/attribute.html
Could you extend the unit test (or add one, if none there)
And do you have some clear name / mail address for the commit?
Thanks!
I don't know how to do that. This is the first time I'm contributing to KDE.
And do you have some clear name / mail address for the commit?
I don't.
I can add the keywords myself then, no problem.
Thought for larger contributions, I really would appreciate some real name, copyright wise I don't think just some pseudonym is really that great.
Great, thanks.
Thought for larger contributions, I really would appreciate some real name, copyright wise I don't think just some pseudonym is really that great.
I have two other things I'd like to fix in d.xml: D17413 and highlighting the delimiters of token strings (q{...}). I don't know if those are big enough to be cause for concern.
I've had these things in my own d.xml for a while and now I thought I'd contribute them back. If there's a better way for me to submit anonymous patches, let me know. I don't care for credit or any intellectual property rights.