add attributes `shared` and `__gshared`
ClosedPublic

Authored by aG0aep6G on Dec 7 2018, 2:41 PM.

Diff Detail

Repository
R216 Syntax Highlighting
Branch
shared-__gshared
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5779
Build 5797: arc lint + arc unit
aG0aep6G created this revision.Dec 7 2018, 2:41 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 7 2018, 2:41 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
aG0aep6G requested review of this revision.Dec 7 2018, 2:41 PM
cullmann requested changes to this revision.Dec 7 2018, 6:43 PM

Google tells me this are valid attributes: https://dlang.org/spec/attribute.html

Could you extend the unit test (or add one, if none there)

And do you have some clear name / mail address for the commit?

Thanks!

This revision now requires changes to proceed.Dec 7 2018, 6:43 PM

Google tells me this are valid attributes: https://dlang.org/spec/attribute.html

Could you extend the unit test (or add one, if none there)

I don't know how to do that. This is the first time I'm contributing to KDE.

And do you have some clear name / mail address for the commit?

I don't.

cullmann accepted this revision.Dec 7 2018, 7:30 PM

I can add the keywords myself then, no problem.
Thought for larger contributions, I really would appreciate some real name, copyright wise I don't think just some pseudonym is really that great.

This revision is now accepted and ready to land.Dec 7 2018, 7:30 PM

I can add the keywords myself then, no problem.

Great, thanks.

Thought for larger contributions, I really would appreciate some real name, copyright wise I don't think just some pseudonym is really that great.

I have two other things I'd like to fix in d.xml: D17413 and highlighting the delimiters of token strings (q{...}). I don't know if those are big enough to be cause for concern.

I've had these things in my own d.xml for a while and now I thought I'd contribute them back. If there's a better way for me to submit anonymous patches, let me know. I don't care for credit or any intellectual property rights.

This revision was automatically updated to reflect the committed changes.