Differential D17380

Avoid deleting ourselves midway through updateShadow
ClosedPublic
Actions

Authored by davidedmundson on Dec 6 2018, 12:26 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:576c6671245c: Avoid deleting ourselves midway through updateShadow
Summary

If updating a shadow means that there should be no shadow, shadow ends
up deleting itself midway through the method.

It's cleaner and safer to leave that to the caller.

This new change matches the existing documentation for
Shadow::updateShadow which states

In case the Property has been withdrawn the method returns @c false.
In that case the owner should delete the Shadow.

Test Plan

Created an ASAN of kwin
Relevant testMaximised no longer fails

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Dec 6 2018, 12:26 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 6 2018, 12:26 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Dec 6 2018, 12:26 PM
zzag accepted this revision.Dec 6 2018, 12:53 PM
This revision is now accepted and ready to land.Dec 6 2018, 12:53 PM
Closed by commit R108:576c6671245c: Avoid deleting ourselves midway through updateShadow (authored by davidedmundson). · Explain WhyDec 6 2018, 12:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshadow.cpp (14 lines)
Mtoplevel.cpp (5 lines)

Diff 46954

View Options

shadow.cpp

Loading...
View Options

toplevel.cpp

Loading...