Diffusion KWin 90a26e2e8d13

Try to invalidate quad cache when shadow is changed

Authored by zzag on Nov 27 2018, 1:25 PM.

Description

Try to invalidate quad cache when shadow is changed

Summary:
213239a0ea0a9c0967bb68d1eda7a8d4d6a09498 tried to address the case when
a wayland client gets shadow after it was mapped, but because of poor
testing from my side, another bug was introduced. If a decoration tooltip
or the user actions popup is shown, then in some cases it can be blank.

Usually, SurfaceInterface::shadowChanged proceeds SurfaceInterface::sizeChanged,
so when the shadow is installed, window quads cache is rebuilt. But
because shell client already knows the geometry of the internal client,
goemetryShapeChanged is not emitted, thus the cache is not updated.

It would be better just to invalidate the cache when the shadow is
installed, uninstalled, or updated. This reduces the number of
unnecessary invocations of Scene::Window::buildQuads and also moves
handling of the window quads cache away from the Shadow class.

BUG: 399490
FIXED-IN: 5.15.0

Test Plan: Decoration tooltips are no longer blank.

Reviewers: KWin, davidedmundson

Reviewed By: KWin, davidedmundson

Subscribers: davidedmundson, graesslin, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D17215

Details

Committed
zzagDec 5 2018, 6:05 PM
Reviewer
KWin
Differential Revision
D17215: Try to invalidate quad cache when shadow is changed
Parents
R108:6f982e88a061: Fix minor EBN issues in the Doxygen code
Branches
Unknown
Tags
Unknown