Don't automatically refresh if the user already asked apt to do so
AbandonedPublic

Authored by apol on Thu, Dec 6, 1:54 AM.

Details

Summary

Just expect apt to do the right thing.

BUG: 401810

Diff Detail

Repository
R134 Discover Software Store
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5737
Build 5755: arc lint + arc unit
apol created this revision.Thu, Dec 6, 1:54 AM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Dec 6, 1:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Thu, Dec 6, 1:54 AM

Seems good to me, and a quick test on a stock Kubuntu install gets the updater registering new updates when the system does its own refresh.

ngraham added a subscriber: ngraham.Sat, Dec 8, 4:40 AM

This helps for Kubuntu (and Neon ?) users, but what about everyone else?

rikmills added a comment.EditedSat, Dec 8, 10:26 AM

This helps for Kubuntu (and Neon ?) users, but what about everyone else?

As the code changed here is apt specific, for non apt distro the updater will continue as before to refresh via packagekit 5 mins after system startup, and then afterwards once every 24 hrs.

That's what I thought. Then it doesn't fully fix 401810, since people not using Kubuntu or Neon will still not have a way to change the update frequency.

rikmills added a comment.EditedSat, Dec 8, 7:13 PM

That's what I thought. Then it doesn't fully fix 401810, since people not using Kubuntu or Neon will still not have a way to change the update frequency.

I don't think this was intended to be a full fix for that in a distro agnostic sense, though it is relevant so posted on that bug. This is specific to apt updates where currently if a x0periodic config files exists then (a) notifier and apt config prompted refreshes will at a minimum double the frequency, and (b) even worse the apt-config setting in days was being misconstrued by the notifier as hours, resulting in even more frequent refreshes. That is what I pointed out and discussed with Aleix a few days ago, which prompted this revision.

apol added a comment.Mon, Dec 10, 12:36 AM

This is apt-specific code, so if apt distros are happy with it, then it's as good as it gets.
It could make sense to do the same for other distros, but that's a different battle.

I'll land on 5.14.

apol abandoned this revision.Mon, Dec 10, 12:38 AM

It's landed, phabricator doesn't let me just close it.
https://commits.kde.org/discover/30de60f05d183e185724e614aad67b06aec987f3