Differential D17373

Fix heap-use-after-free
AbandonedPublic
Actions

Authored by zzag on Dec 5 2018, 8:18 PM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

After Scene::Window::updateShadow is called, this is a dangling
pointer. So, we have to capture m_topLevel instead.

Test Plan

It should make CI a little bit happier.

Diff Detail

Repository
R108 KWin
Branch
fix-heap-use-after-free
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5731
Build 5749: arc lint + arc unit
zzag created this revision.Dec 5 2018, 8:18 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 5 2018, 8:18 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Dec 5 2018, 8:18 PM
davidedmundson added a subscriber: davidedmundson.Dec 6 2018, 2:37 AM

Either ship it, or see my comment and I'll post that.

shadow.cpp
337

That was a nasty trap, good thing ASAN was there.

Alternative suggestion: https://phabricator.kde.org/P278

It matches the existing documentation for updateShadow and doesn't have surprise object deletions.

zzag abandoned this revision.Dec 6 2018, 8:48 AM
In D17373#371867, @davidedmundson wrote:

Either ship it, or see my comment and I'll post that.

I prefer your solution more.

Revision Contents
Changeset List

PathPackages
Mshadow.cpp (8 lines)

Diff 46915

View Options

shadow.cpp

Loading...