BuildView: Improve user information when build fails
ClosedPublic

Authored by loh.tar on Sun, Dec 2, 9:34 AM.

Details

Summary

...due to wrong set build path

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Sun, Dec 2, 9:34 AM
Restricted Application added a subscriber: kwrite-devel. · View Herald TranscriptSun, Dec 2, 9:34 AM
loh.tar requested review of this revision.Sun, Dec 2, 9:34 AM

The text (the look) may OK but I think could be improved. Please give exact advice.

sars accepted this revision.Sun, Dec 2, 3:18 PM
sars added a subscriber: sars.

I think the text could be "Cannot run command: %1\nWork path %2 does not exist."

This revision is now accepted and ready to land.Sun, Dec 2, 3:18 PM

I think the text could be "Cannot run command: %1\nWork path %2 does not exist."

No sure if that's a request to me to change that, or only a thought for further discusion.
My taste is not to include the argument into the sentence, so I offer a slightly modification. Nevertheless looks that to me a little long.

Furthermore I like to suggest to change the other box text to fit the style of this box, howsoever it will be decided.

ngraham added a subscriber: ngraham.Sun, Dec 2, 6:26 PM

That looks pretty sensible to me.

sars added a comment.Sun, Dec 2, 7:05 PM

Let's take that one :)

loh.tar updated this revision to Diff 46762.Mon, Dec 3, 4:18 AM
loh.tar edited the test plan for this revision. (Show Details)
  • Updated as accepted
  • Cleared Test Plan to avoid unneded stuff in commit message
This revision was automatically updated to reflect the committed changes.