Differential D17290

Don't set DCMAKE_BUILD_TYPE in kf5-frameworks-build-include
ClosedPublic
Actions

Authored by gregormi on Dec 1 2018, 8:00 PM.

Details

Reviewers
mpyne
dfaure
Commits
R365:78a666fd0067: Don't set DCMAKE_BUILD_TYPE in kf5-frameworks-build-include
Summary

In kde/src/log/2018-12-01-04/kconfig/cmake.log, I found this:

# kdesrc-build running: 'cmake' '/home/gregor/kde/src/frameworks/kconfig' '-DCMAKE_CXX_COMPILER_LAUNCHER=ccache' '-GNinja' '-DCMAKE_BUILD_TYPE=Debug' '-DBUILD_TESTING=TRUE' '-DCMAKE_BUILD_TYPE:STRING=debug' '-DCMAKE_CXX_FLAGS:STRING=-pipe ' '-DCMAKE_INSTALL_PREFIX=/home/gregor/kde/usr' '-DCMAKE_PREFIX_PATH=/usr'
# from directory: /home/gregor/kde/build/frameworks/kconfig
-- The C compiler identification is GNU 8.2.1
-- The CXX compiler identification is GNU 8.2.1
...

Note, that CMAKE_BUILD_TYPE from my global .kdesrc-buildrc gets overridden from "Debug" to "debug". For me, this came surprising (also the lowercase "debug" is less common than the capital D).

This change removes the definition of CMAKE_BUILD_TYPE from kf5-frameworks-build-include.

Diff Detail

Repository
R365 kdesrc-build
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gregormi requested review of this revision.Dec 1 2018, 8:00 PM
gregormi created this revision.
gregormi edited the summary of this revision. (Show Details)Dec 1 2018, 8:09 PM
gregormi added a reviewer: mpyne.
gregormi updated this revision to Diff 46649.Dec 1 2018, 8:10 PM
gregormi edited the summary of this revision. (Show Details)
This comment was removed by gregormi.
gregormi updated this revision to Diff 46650.Dec 1 2018, 8:13 PM
This comment was removed by gregormi.
gregormi updated this revision to Diff 46651.Dec 1 2018, 8:13 PM
This comment was removed by gregormi.
gregormi updated this revision to Diff 46653.Dec 1 2018, 8:17 PM
  • remove last commit
dfaure accepted this revision.Dec 2 2018, 2:43 PM

Fair point, one can set this in kdesrc-buildrc anyway.

BTW kactivities isn't just an example, it's actually needed (not the build-type though). But it also serves as an example if other modules need module-specific options :-)

This revision is now accepted and ready to land.Dec 2 2018, 2:43 PM
gregormi updated this revision to Diff 46731.Dec 2 2018, 6:09 PM
  • Adapt comment and remove one more CMAKE_BUILD_TYPE
gregormi edited the summary of this revision. (Show Details)Dec 2 2018, 6:11 PM
Closed by commit R365:78a666fd0067: Don't set DCMAKE_BUILD_TYPE in kf5-frameworks-build-include (authored by Gregor Mi <codestruct@posteo.net>, committed by gregormi). · Explain WhyDec 2 2018, 6:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkf5-frameworks-build-include (12 lines)

Diff 46732

View Options

kf5-frameworks-build-include

Loading...