When an empty file is send from the desktop SharePlugin onPacketReceived
does not see a payload so the packet is discarded
Details
Details
- Reviewers
albertvaka - Group Reviewers
KDE Connect - Commits
- R225:04e605bcf90f: Handle receiving an empty file
Send an empty file from the desktop
Verify that a notification is shown notifying the user that a file was received and that file has been created in the filesystem
Diff Detail
Diff Detail
- Repository
- R225 KDE Connect - Android application
- Branch
- receive_empty_file
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5555 Build 5573: arc lint + arc unit
src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java | ||
---|---|---|
115 ↗ | (On Diff #46466) | I think checking for payload is unnecessary now |
src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java | ||
---|---|---|
215 ↗ | (On Diff #46466) | On the desktop side this checks hasPayload() instead. I don't think it changes anything but better to be consistent. |
src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java | ||
---|---|---|
131 | Remove log? |