${PHONON_LIBS} as the name suggests links all libraries, that includes
the experimental library. it's not even used though.
move to imported target to avoid linking experimental and also get rid
of the include_directories call
Details
Details
- Reviewers
broulik apol - Commits
- R305:f6d55baf5aa8: do not attempt to link phononexperimental :O
➜ DESTDIR=x ninja install &> /dev/null; grep -ri phonon4qt5experimental x x/usr/lib/x86_64-linux-gnu/cmake/KF5NotifyConfig/KF5NotifyConfigTargets-debug.cmake: IMPORTED_LINK_DEPENDENT_LIBRARIES_DEBUG "KF5::I18n;KF5::KIOWidgets;Phonon::phonon4qt5;Phonon::phonon4qt5experimental;Qt5::DBus"
with new code
➜ DESTDIR=x ninja install &> /dev/null; grep -ri phonon4qt5experimental x
Diff Detail
Diff Detail
- Repository
- R305 KNotifyConfig
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.