Added proxy and user settings according to:
https://developer.gnome.org/NetworkManager/stable/settings-proxy.html https://developer.gnome.org/NetworkManager/stable/settings-user.html
Details
- Reviewers
jgrulich - Commits
- R282:ee74458db659: Add proxy and user setting
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/settings/proxysetting.cpp | ||
---|---|---|
26 | It looks that the proxy setting has been introduced in NetworkManager 1.6. This means that for all property defines, you have to add ifdef the same way you did for ip tunnel setting. | |
src/settings/proxysetting.h | ||
36 | Represents proxy setting | |
53 | This can be turned into an enum. Possible values are: So I would do: | |
src/settings/usersetting.cpp | ||
26 | User setting was introduced with NM 1.8. Here should be ifdef to check the version and define NM_SETTING_USER_DATA in case the version is older. | |
28 | Should be NM_SETTING_USER_SETTING_NAME | |
src/settings/usersetting.h | ||
36 | Represents user setting | |
53 | No reason for such a big space. |
src/settings/iptunnelsetting.cpp | ||
---|---|---|
35 ↗ | (On Diff #46467) | This is an unrelated change, submit it in a different review, but thanks for spotting this. |
src/settings/proxysetting.cpp | ||
26 | I said NM 1.6, not 1.16 and you need !NM_CHECK_VERSION(1, 6, 0). | |
src/settings/proxysetting.h | ||
42 | Coding style. It should be: enum Mode { | |
src/settings/usersetting.cpp | ||
26 | Same here. It should be !NM_CHECK_VERSION(1, 8, 0). |
src/settings/proxysetting.cpp | ||
---|---|---|
26 |