Differential D17209

[effects/fadingpopups] Don't animate KDE Plasma splash screen
ClosedPublic
Actions

Authored by zzag on Nov 28 2018, 9:28 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:3d57324ed218: [effects/fadingpopups] Don't animate KDE Plasma splash screen
Summary

In order to be compatible with the monolithic Fade effect, this effect
animates special windows (e.g. notifications, etc) as well, but some
of those special windows shouldn't be animated by this effect (e.g.
KDE Plasma splash screen).

Test Plan

Started new Plasma on Wayland session, the KDE Plasma splash screen
smoothly faded out without flickering/blinking, etc.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Nov 28 2018, 9:28 AM
Restricted Application added a project: KWin. · View Herald TranscriptNov 28 2018, 9:28 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Nov 28 2018, 9:28 AM
zzag edited the summary of this revision. (Show Details)Nov 28 2018, 10:26 AM
davidedmundson accepted this revision.Nov 29 2018, 1:49 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
effects/fadingpopups/package/contents/code/main.js
23

we could do with standardising this list in EffectWindow somewhere

This revision is now accepted and ready to land.Nov 29 2018, 1:49 PM
Closed by commit R108:3d57324ed218: [effects/fadingpopups] Don't animate KDE Plasma splash screen (authored by zzag). · Explain WhyNov 29 2018, 2:17 PM
This revision was automatically updated to reflect the committed changes.
abetts added a subscriber: abetts.Nov 29 2018, 3:08 PM

What would this look like in practice? Before/after?

Revision Contents
Changeset List

Diff 46471

View Options

effects/fadingpopups/package/contents/code/main.js

Loading...