Fix Windows CI build issues caused by startPreviewScan slot
ClosedPublic

Authored by trufanov on Tue, Nov 27, 2:18 PM.

Details

Summary

I've been contacted re failed Windows Dependency Build jobs on the CI system which was caused by my commit in libksane (https://phabricator.kde.org/D16795).

The log is: https://build.kde.org/job/Administration/job/Dependency%20Build%20Applications%20kf5-qt5%20WindowsMSVCQt5.11/21/console

Looks like libksane uses another codebase while building for Win (files in ksanetwain/*). In particular it tries to compile ksanetwain/ktwain_widget.cpp with /src/ksanewidget.h instead of /src/ksanewidget*.cpp .
Looks like windows implementation contains only dummy functions for this class so this patch should be enough.

I didn't test this patch yet - i need virtual machine with Win and VS for that and not sure that i'll be able to test it even after setting them up. But it should be enough to fix CI problem. I'll post here if i'll be able to make sure in this.

Diff Detail

Repository
R382 KSane Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trufanov requested review of this revision.Tue, Nov 27, 2:18 PM
trufanov created this revision.
trufanov edited the summary of this revision. (Show Details)Tue, Nov 27, 2:21 PM

Hi, Kåre
I won't be able to test this. It's hard to setup build chain in virtual machine and it depends on some other kf5 libs.
How about just commiting it? As Win compilation is already broken it won't make worse

Any news on getting this committed @sars ?

sars added a comment.Fri, Dec 7, 7:50 AM

Sorry! This problem has totally passed me by before this... I'll have a look.

sars accepted this revision.Fri, Dec 7, 7:54 AM

There is not much else we can do than just have a dummy like this, with the current state of the twain wrapper.

Thanks for fixing

This revision is now accepted and ready to land.Fri, Dec 7, 7:54 AM

Thanks for approving.

Could you land this please @trufanov?

This revision was automatically updated to reflect the committed changes.

Done, let me know if CI fails again.

Thanks, i'll advise if this doesn't fix the issue.