Export preview slot
ClosedPublic

Authored by trufanov on Nov 9 2018, 11:34 PM.

Details

Summary

I would like to add a new D-Bus hotkey for Skanlite which allows to start getting preview image. But KSane widget keeps required slot private. It should be made accessible for external app.
I'm using skanlite via global D-Bus hotkeys while watching fullscreen video. This shortcut isn't critical as user still needs to check GUI for preview result. But at least user don't need to get back to GUI to start preview scanning.

Anyway it's a minor tweak which causes (most likely) a binary compatibility break. So I'm fine if it won't reach the codebase. I have it in my fork anyway. If it's acceptable then I'll submit a diff for Skanlite depending on this patch.

Diff Detail

Repository
R382 KSane Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trufanov requested review of this revision.Nov 9 2018, 11:34 PM
trufanov created this revision.
sars accepted this revision.Nov 10 2018, 7:46 PM

Adding a function is not breaking backwards compatibility. You can still use Skanlite compiled against an older version with this new version.

Adding a function is not among the no-no-list in https://community.kde.org/Policies/Binary_Compatibility_Examples :)

Please commit!

This revision is now accepted and ready to land.Nov 10 2018, 7:46 PM
This revision was automatically updated to reflect the committed changes.