Change Details

I've been contacted re failed Windows Dependency Build jobs on the CI system which was caused by my commit in libksane (https://phabricator.kde.org/D16813). The log is: https://build.kde.org/job/Administration/job/Dependency%20Build%20Applications%20kf5-qt5%20WindowsMSVCQt5.11/21/console Looks like libksane uses another codebase while building for Win (files in ksanetwain/*). In particular it tries to compile ksanetwain/ktwain_widget.cpp with /src/ksanewidget.h instead of /src/ksanewidget*.cpp . Looks like windows implementation contains only dummy functions for this class so this patch should be enough. I didn't test this patch yet - i need virtual machine with Win and VS for that and not sure that i'll be able to test it even after setting them up. But it should be enough to fix CI problem. I'll post here if i'll be able to make sure in this.

I've been contacted re failed Windows Dependency Build jobs on the CI system which was caused by my commit in libksane (https://phabricator.kde.org/D16795). The log is: https://build.kde.org/job/Administration/job/Dependency%20Build%20Applications%20kf5-qt5%20WindowsMSVCQt5.11/21/console Looks like libksane uses another codebase while building for Win (files in ksanetwain/*). In particular it tries to compile ksanetwain/ktwain_widget.cpp with /src/ksanewidget.h instead of /src/ksanewidget*.cpp . Looks like windows implementation contains only dummy functions for this class so this patch should be enough. I didn't test this patch yet - i need virtual machine with Win and VS for that and not sure that i'll be able to test it even after setting them up. But it should be enough to fix CI problem. I'll post here if i'll be able to make sure in this.

I've been contacted re failed Windows Dependency Build jobs on the CI system which was caused by my commit in libksane (https://phabricator.kde.org/D16813795). The log is: https://build.kde.org/job/Administration/job/Dependency%20Build%20Applications%20kf5-qt5%20WindowsMSVCQt5.11/21/console Looks like libksane uses another codebase while building for Win (files in ksanetwain/*). In particular it tries to compile ksanetwain/ktwain_widget.cpp with /src/ksanewidget.h instead of /src/ksanewidget*.cpp . Looks like windows implementation contains only dummy functions for this class so this patch should be enough. I didn't test this patch yet - i need virtual machine with Win and VS for that and not sure that i'll be able to test it even after setting them up. But it should be enough to fix CI problem. I'll post here if i'll be able to make sure in this.