Integrated GCCreationHandler with balancebox
ClosedPublic

Authored by amankumargupta on Nov 25 2018, 9:45 AM.

Details

Summary

Tested on all general and corner cases. Works good.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
amankumargupta created this revision.Nov 25 2018, 9:45 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 25 2018, 9:45 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
jjazeix accepted this revision.Nov 25 2018, 10:40 AM
jjazeix added a subscriber: jjazeix.

Will existing created levels (via the old method) still available? If not, we need to be able to convert the old levels format to the new one and don't lose them

src/activities/balancebox/Balancebox.qml
505

is there a way to handle this property only in the creationHandler item?
parent: (condition_to_be_determined) ? background : editor
(if no clean way, we can keep it like this)

This revision is now accepted and ready to land.Nov 25 2018, 10:40 AM

Will existing created levels (via the old method) still available? If not, we need to be able to convert the old levels format to the new one and don't lose them

Yes, the existing created levels will still be available and will be loaded by default when the activity is loaded in "user" mode after updating the app. Line 40 in the diff will help to get better insight.

amankumargupta marked an inline comment as done.Nov 25 2018, 11:12 AM
amankumargupta added inline comments.
src/activities/balancebox/Balancebox.qml
505

Thanks! Modified it.