Add some i18n(), avoid using QString::number() as recommended here:
https://techbase.kde.org/Development/Tutorials/Localization/i18n_Krazy#Number_Formatting
Details
Details
- Reviewers
lancaster mutlaqja - Group Reviewers
KStars - Commits
- R321:a8073c84410a: Make Star Profile Viewer localizable
Only message extraction was tested, no testing of compilation or testing in vivo were performed.
Diff Detail
Diff Detail
- Repository
- R321 KStars
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
You should use QString("%L1").arg(variable, width, 'f', précision) to properly format floating point values using the decimal point of the locale
Comment Actions
According to the document Yuri posted, I think he got it right. The arg method appears to be the old way to do it.
i18n("Found key: %1", key); correct
i18n("Found key: %1").arg(key); ***wrong
Comment Actions
Assuming you were talking about his changes here of course, I might misunderstand what you mean
Comment Actions
In the case of floating point, either QString("%L1").arg() or ki18n().subs() should be used, and HFR is a float (no i18n with args here).
But I didn't investigate whether, while the QString method systematically used the system locale, the ki18n could handle a locale switch in the application without system locale changes.