Creating the FitsTools Panel and Histogram Fixes
ClosedPublic
Actions

Authored by lancaster on Nov 25 2018, 7:16 AM.

Details

Reviewers

Commits

R321:5c39c2da86fb: Creating the FitsTools Panel and Histogram Fixes

Summary

Creating the FitsTools Panel on the left side of the FITSViewer to contain the Histogram, the FITSHeader, and the Statistics.
In the future, this will be a good location for parameters for liveStacking and possibly a recent tab too.
Also fixed some bugs in the Histogram and made the histogram more responsive.

Diff Detail

Repository

R321 KStars

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

lancaster created this revision.Nov 25 2018, 7:16 AM

Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 25 2018, 7:16 AM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

lancaster requested review of this revision.Nov 25 2018, 7:16 AM

Harbormaster completed remote builds in B5347: Diff 46176.Nov 25 2018, 7:16 AM

yurchor added a subscriber: yurchor.Nov 25 2018, 7:34 AM

yurchor added inline comments.

kstars/fitsviewer/fitstab.cpp
100	Can it be fitsTools->addItem(statWidget, i18n("Statistics")); to enable translations?
102	Same here.
106	Same here.

Fixing Translations issues

Updating D17147: Creating the FitsTools Panel on the left side of the FITSViewer to contain

the Histogram, the FITSHeader, and the Statistics.
In the future, this will be a good location for parameters for
liveStacking and possibly a recent tab too.
Also...

Harbormaster completed remote builds in B5348: Diff 46178.Nov 25 2018, 7:54 AM

Fixed

mutlaqja commandeered this revision.Nov 25 2018, 3:15 PM

mutlaqja added a reviewer: lancaster.

Taking it back since Jasem accidentally did this :-)

lancaster retitled this revision from Creating the FitsTools Panel on the left side of the FITSViewer to contain the Histogram, the FITSHeader, and the Statistics. In the future, this will be a good location for parameters for liveStacking and possibly a recent tab too. Also... to Creating the FitsTools Panel and Histogram Fixes.Nov 25 2018, 5:47 PM

lancaster edited the summary of this revision. (Show Details)

I'm still new to Phabricator so am having some troubles still. Sorry about the issues.

Looks great! Btw, on a slightly different topic, what does the histogram looks "weird"? is it because it's linear and we're used to see non-linear histograms? Any change of black vs white controls to manage contrast within the histogram itself? like a simple control to drag?

mutlaqja requested changes to this revision.Nov 26 2018, 8:16 PM

mutlaqja added inline comments.

kstars/fitsviewer/fitstab.h
91	Let us try to avoid raw pointers in new code. use QPointer<QDialog> ..etc

This revision now requires changes to proceed.Nov 26 2018, 8:16 PM

Fixing issue with QSharedPointer

Merge branch 'master' of https://github.com/KDE/kstars

Harbormaster completed remote builds in B5404: Diff 46289.Nov 26 2018, 8:55 PM

Fixing QPointer

mutlaqja accepted this revision.Nov 26 2018, 8:59 PM

This revision is now accepted and ready to land.Nov 26 2018, 8:59 PM

Closed by commit R321:5c39c2da86fb: Creating the FitsTools Panel and Histogram Fixes (authored by lancaster, committed by mutlaqja). · Explain WhyNov 26 2018, 9:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kstars/fitsviewer/fitsheaderdialog.ui (26 lines)
M			kstars/fitsviewer/fitshistogram.h (1 line)
M			kstars/fitsviewer/fitshistogram.cpp (14 lines)
M			kstars/fitsviewer/fitshistogramui.ui (208 lines)
M			kstars/fitsviewer/fitstab.h (28 lines)
M			kstars/fitsviewer/fitstab.cpp (74 lines)
M			kstars/fitsviewer/statform.ui (162 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	46176	2cc8ac8		Nov 25 2018, 7:16 AM	★	★
Diff 2	46178	2cc8ac8	Fixing Translations issues	Nov 25 2018, 7:54 AM	★	★
Diff 3	46289	a8073c8	Fixing issue with QSharedPointer	Nov 26 2018, 8:55 PM	★	★
Diff 4	46291	d60eefc	R321:5c39c2da86fb008e0731b43598bfa1b3fce1f074	Nov 26 2018, 9:00 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
ef6324e9cddf	ab12ae28c801	470c5300731c a8073c84410a	Robert Lancaster	Merge branch 'master' of https://github.com/KDE/kstars	Nov 25 2018, 5:59 PM
470c5300731c	928a6cda03a8	2cc8ac8cdb0b	Robert Lancaster	Creating the FitsTools Panel on the left side of the FITSViewer to contain the… (Show More…)	Nov 25 2018, 7:14 AM