[KUrlNavigator] Re-activate on mouse middle button click
ClosedPublic

Authored by thsurrel on Nov 22 2018, 10:46 PM.

Details

Summary

When using the mouse middle button to open a folder when
the kurlnavigator was disabled, it was not re-activated.

BUG: 386453

Test Plan

In Dolphin, open the split view and use the mouse middle button
to open a folder in a new tab on the 'disabled' splitted view.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thsurrel created this revision.Nov 22 2018, 10:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 22 2018, 10:46 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
thsurrel requested review of this revision.Nov 22 2018, 10:46 PM
thsurrel edited the summary of this revision. (Show Details)Nov 22 2018, 10:49 PM
thsurrel edited the test plan for this revision. (Show Details)
ngraham accepted this revision.Nov 24 2018, 3:31 PM
ngraham added a subscriber: ngraham.

This approach makes sense to me and works beautifully!

This revision is now accepted and ready to land.Nov 24 2018, 3:31 PM
elvisangelaccio accepted this revision.Nov 24 2018, 4:43 PM

We could have used KUrlNavigator::mouseReleaseEvent() where we already have the same check, but this is also fine.

I tried that too, but it was not working for Dolphin. It did reactivate correctly the disabled split view, but the tab was not opened, I guess we were missing an event.

This revision was automatically updated to reflect the committed changes.