When using the list header to change the role and order, if one
changes the order to descending and then changes role, dolphin
also changes the order back to ascending. This results in sorting
the list of files twice in a row. This patch removes the first
(useless) sort.
Details
Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:b714604a6795: Do not sort twice when changing role and order at the same time
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- arc_sort_optim (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5402 Build 5420: arc lint + arc unit
| src/kitemviews/kfileitemmodel.cpp | ||
|---|---|---|
| 841 | Please remove, this will only add noise. And you could accomplish the same goal by properly setting your QT_MESSAGE_PATTERN variable. | |
| src/kitemviews/kitemmodelbase.h | ||
| 84–89 | Please update the apidox. It should say that the implementation should resort only if resortItems is true. | |
| 263–271 | Same here, the apidox needs to be updated. | |
| src/kitemviews/private/kitemlistheaderwidget.cpp | ||
| 223–224 | How about calling the variable resetSortOrder ? | |