Remove ununsed wdfInc parameter for addTerm and addPositionTerm
ClosedPublic
Actions

Authored by bruns on Nov 22 2018, 2:20 AM.

Details

Reviewers

ngraham
poboiko
apol

Group Reviewers

Baloo
Frameworks

Commits

R293:26a879838ace: Remove ununsed wdfInc parameter for addTerm and addPositionTerm

Summary

wdf (word frequency) is neither saved to the database nor used anywhere
else. It is also not tested, and has no documented semantics.

Remove add*BoolTerm(), as it is identical to add*Term() after the change.

This change affects the API and ABI of libKF5BalooEngine, but it is an
internal library interface only used by libKF5Baloo. Only the latter
is exported.

Test Plan

ctest

Diff Detail

Repository

R293 Baloo

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bruns created this revision.Nov 22 2018, 2:20 AM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptNov 22 2018, 2:20 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

bruns requested review of this revision.Nov 22 2018, 2:20 AM

Harbormaster completed remote builds in B5241: Diff 45990.Nov 22 2018, 2:20 AM

I'd change the wording. It's being exported, only that the headers aren't being installed so it's not really usable. ;)

This revision is now accepted and ready to land.Nov 22 2018, 11:52 AM

Closed by commit R293:26a879838ace: Remove ununsed wdfInc parameter for addTerm and addPositionTerm (authored by bruns). · Explain WhyNov 23 2018, 12:33 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/engine/document.h (21 lines)
M			src/engine/document.cpp (34 lines)
M			src/engine/termgenerator.h (10 lines)
M			src/engine/termgenerator.cpp (20 lines)
M			src/file/basicindexingjob.cpp (10 lines)
M			src/file/extractor/result.cpp (10 lines)