The mimetype is matched with "powerpoint" and "excel" already, no need
to add it to the list a second time.
This has no influence on DB contents, as adding a term is idempotent, but
makes the QHash here and the returned QVector<Type> slightly smaller.
Details
Details
- Reviewers
ngraham poboiko lbeltrame - Group Reviewers
Baloo Frameworks - Commits
- R293:149c8b2379df: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs
Diff Detail
Diff Detail
- Repository
- R293 Baloo
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
LGTM; just a minor change needed.
| src/file/basicindexingjob.cpp | ||
|---|---|---|
| 153 | Remove instead of committing commented out code? | |
| src/file/basicindexingjob.cpp | ||
|---|---|---|
| 153 | I prefer not to remove it, at least not completely. I think it is useful to have the mimetypes listed explicitly, so if someone greps for it it is obvious these are already covered. // The pre-XML MS Office formats are already covered by the "contains" above: // "application/vnd.ms-powerpoint" // "application/vnd.ms-excel" | |