[thumbnailer appimage] Fix building with libappimage not in system path
ClosedPublic

Authored by kossebau on Nov 22 2018, 12:38 AM.

Details

Summary

The current CMake Config file of libappimage does not specify any
imported target nameed "appimage". Instead it provides a shared lib
target "libappimage" and a static lib target "libappimage_static".
Both though are also broken in that they have targets to further
dependencies in their link list, which though are only defined in the
internal build system, but not provided with the installed CMake Config
file.

Additionally the LIBAPPIMAGE_INCLUDE_DIRS is currently not set,
https://github.com/AppImage/libappimage/pull/17 hopefully fixes this
for future versions.

The previous simple "appimage" only worked if libappimage was installed
to an otherwise known prefix, so include dirs and library paths were among
the ones considered, and the linker would find libappimage via -lappimage.

Test Plan

Building against current version of libappimage installed to custom prefix
works, as well as building against the patched version.

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Nov 22 2018, 12:38 AM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptNov 22 2018, 12:38 AM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Nov 22 2018, 12:38 AM

Don't know much cmake but still builds fine here with this change, so +1 from me

There will be packages for libappimage (hopefully) soon, which provide a .pc file. This provides an alternative to using these generated CMake config files, which can be used through CMake's pkg-config module (find_package(PkgConfig)).

This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2018, 3:58 AM
This revision was automatically updated to reflect the committed changes.