Differential D17055

Avoid Q_FOREACH
ClosedPublic
Actions

Authored by loh.tar on Nov 20 2018, 3:54 PM.

Details

Reviewers
davidedmundson
cullmann
Commits
R246:59fcd4bd2aff: Avoid Q_FOREACH
Summary

VoikkoDict, HunspellClient, HSpellDict, GuessLanguage, parsetrigrams

Diff Detail

Repository
R246 Sonnet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Nov 20 2018, 3:54 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 20 2018, 3:54 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
loh.tar requested review of this revision.Nov 20 2018, 3:54 PM
cullmann accepted this revision.Dec 9 2018, 2:57 PM
cullmann added a subscriber: cullmann.

I would say it looks reasonable and either only stuff const stuff or fresh things inside the for.

This revision is now accepted and ready to land.Dec 9 2018, 2:57 PM
Closed by commit R246:59fcd4bd2aff: Avoid Q_FOREACH (authored by loh.tar, committed by cullmann). · Explain WhyDec 12 2018, 7:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47477

View Options

data/parsetrigrams.cpp

Loading...
View Options

src/core/guesslanguage.cpp

Loading...
View Options

src/plugins/hspell/hspelldict.cpp

Loading...
View Options

src/plugins/hunspell/hunspellclient.cpp

Loading...
View Options

src/plugins/voikko/voikkodict.cpp

Loading...