For some reason, the centers of the generated PNGs are not the centers of the crosshairs. I had to move the 1x crosshairs down and to the left by 2px, the 1.5x crosshairs by 3px and the 2x crosshairs by 3px (it's more centered than 4px).
Details
Details
Breeze 1x
Breeze 1.5x
Breeze 2x
Breeze Snow 1x
Breeze Snow 1.5x
Breeze Snow 2x
Diff Detail
Diff Detail
- Repository
- R31 Breeze
- Branch
- center-crosshair (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 5167 Build 5185: arc lint + arc unit
Comment Actions
Whoops! Nice find, and nice fix. Since the other crosshair patch went into the Plasma/5.12 stable branch, let's do the same thing here. You wanna have another go at https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22?