Fix uncentered crosshairs
ClosedPublic

Authored by ndavis on Nov 20 2018, 9:10 AM.

Details

Summary

For some reason, the centers of the generated PNGs are not the centers of the crosshairs. I had to move the 1x crosshairs down and to the left by 2px, the 1.5x crosshairs by 3px and the 2x crosshairs by 3px (it's more centered than 4px).

Test Plan

Breeze 1x


Breeze 1.5x

Breeze 2x

Breeze Snow 1x

Breeze Snow 1.5x

Breeze Snow 2x

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Nov 20 2018, 9:10 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 20 2018, 9:10 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Nov 20 2018, 9:10 AM
ndavis edited the test plan for this revision. (Show Details)Nov 20 2018, 9:19 AM
ngraham accepted this revision.Nov 20 2018, 11:25 PM
ngraham added a subscriber: ngraham.

Whoops! Nice find, and nice fix. Since the other crosshair patch went into the Plasma/5.12 stable branch, let's do the same thing here. You wanna have another go at https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22?

This revision is now accepted and ready to land.Nov 20 2018, 11:25 PM

Whoops! Nice find, and nice fix. Since the other crosshair patch went into the Plasma/5.12 stable branch, let's do the same thing here. You wanna have another go at https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22?

Sure. I'll let you know if I have trouble again.

This revision was automatically updated to reflect the committed changes.