DictionaryComboBoxTest: Add stretch to avoid expanding Dump button
ClosedPublic
Actions

Authored by loh.tar on Nov 19 2018, 9:26 PM.

Details

Reviewers

Group Reviewers

Frameworks
VDG

Commits

R246:3247994e52a6: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

Test Plan

Original: Note the ellipsis in the middle. A reason to expand the window

With and without patch

Sorry to bother you with this pettiness.

Diff Detail

Repository

R246 Sonnet

Lint

Lint Skipped

Unit

Unit Tests Skipped

loh.tar created this revision.Nov 19 2018, 9:26 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptNov 19 2018, 9:26 PM

loh.tar requested review of this revision.Nov 19 2018, 9:26 PM

loh.tar added a reviewer: Frameworks.Nov 24 2018, 6:01 PM

loh.tar edited the test plan for this revision. (Show Details)Nov 28 2018, 5:14 PM

loh.tar added a reviewer: VDG.

So this patch makes the Dump button much wider?

Um, no(?) In that case I would have named this patch "Add stretch to ensure Dump button is expanding"
Sorry, next time I try to describe the pics more precise.

Ah, I see now. A smaller dump. :)

This revision is now accepted and ready to land.Nov 28 2018, 7:21 PM

Do you have commit access?

No, but that's fine. One thing less where I can make mistakes :-)
Should your next question be regarding author ship, take a look at edbf2e36c805
Thanks.

Closed by commit R246:3247994e52a6: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button (authored by loh.tar, committed by ngraham). · Explain WhyNov 28 2018, 10:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			examples/dictionarycombobox.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45835			Nov 19 2018, 9:19 PM	★	★
Diff 2	46435	07605f6	R246:3247994e52a669b4a549a62306a81906946e1d85	Nov 28 2018, 10:47 PM	★	★

Diff 45835

View Options

examples/dictionarycombobox.cpp