Differential D17026

DictionaryComboBoxTest: Add stretch to avoid expanding Dump button
ClosedPublic
Actions

Authored by loh.tar on Nov 19 2018, 9:26 PM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
VDG
Commits
R246:3247994e52a6: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button
Test Plan

Original: Note the ellipsis in the middle. A reason to expand the window

With and without patch

Sorry to bother you with this pettiness.

Diff Detail

Repository
R246 Sonnet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Nov 19 2018, 9:26 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 19 2018, 9:26 PM
loh.tar requested review of this revision.Nov 19 2018, 9:26 PM
loh.tar edited the test plan for this revision. (Show Details)Nov 28 2018, 5:14 PM
loh.tar added a reviewer: VDG.
ngraham added a subscriber: ngraham.Nov 28 2018, 5:18 PM

So this patch makes the Dump button much wider?

loh.tar added a comment.Nov 28 2018, 7:17 PM

Um, no(?) In that case I would have named this patch "Add stretch to ensure Dump button is expanding"
Sorry, next time I try to describe the pics more precise.

ngraham accepted this revision.Nov 28 2018, 7:21 PM

Ah, I see now. A smaller dump. :)

This revision is now accepted and ready to land.Nov 28 2018, 7:21 PM
ngraham added a comment.Nov 28 2018, 7:21 PM

Do you have commit access?

loh.tar added a comment.Nov 28 2018, 8:52 PM

No, but that's fine. One thing less where I can make mistakes :-)
Should your next question be regarding author ship, take a look at edbf2e36c805
Thanks.

Closed by commit R246:3247994e52a6: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button (authored by loh.tar, committed by ngraham). · Explain WhyNov 28 2018, 10:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mexamples/dictionarycombobox.cpp (2 lines)

Diff 46435

View Options

examples/dictionarycombobox.cpp

Loading...